DRIVERS-3131: No explicitly provided properties with MONGODB-AWS #1847
+46
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
force-pushed
the
DRIVERS-3131
branch
from
cb6a6eb to
30808eb
Compare
dariakp
requested changes
Sep 30, 2025
dariakp
changed the title
dariakp
requested changes
Oct 1, 2025
blink1073
reviewed
Oct 6, 2025
dariakp
requested changes
Oct 6, 2025
source/auth/tests/mongodb-aws.md
Outdated
| Drivers MUST test the following scenarios: | ||
|
|
||
| 1. `Regular Credentials`: Auth via an `AWS_ACCESS_KEY_ID` and `AWS_SECRET_ACCESS_KEY` pair | ||
| 1. `Regular Credentials`: Auth via an `AWS_ACCESS_KEY_ID` and `AWS_SECRET_ACCESS_KEY` pair *Removed* |
There was a problem hiding this comment.
Don't we still want to test this with env vars?
There was a problem hiding this comment.
Did you by any chance forget to push this change?
|
This has been fixed. |
dariakp
requested changes
Oct 7, 2025
source/auth/tests/mongodb-aws.md
Outdated
| Drivers MUST test the following scenarios: | ||
|
|
||
| 1. `Regular Credentials`: Auth via an `AWS_ACCESS_KEY_ID` and `AWS_SECRET_ACCESS_KEY` pair | ||
| 1. `Regular Credentials`: Auth via an `AWS_ACCESS_KEY_ID` and `AWS_SECRET_ACCESS_KEY` pair *Removed* |
There was a problem hiding this comment.
Did you by any chance forget to push this change?
|
#1847 (comment) Yes, just pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes supplying credentials for MONGODB-AWS in the URI or client options in the auth spec and adds new tests.
Tools changes: mongodb-labs/drivers-evergreen-tools#691
Node implementation: mongodb/node-mongodb-native#4689
Please complete the following before merging:
clusters).